D2481: wireproto: use named arguments for commandentry
indygreg (Gregory Szorc)
phabricator at mercurial-scm.org
Tue Feb 27 23:49:59 UTC 2018
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
We'll be adding more arguments in upcoming commits. Using named
arguments will make the code easier to read.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2481
AFFECTED FILES
mercurial/wireproto.py
CHANGE DETAILS
diff --git a/mercurial/wireproto.py b/mercurial/wireproto.py
--- a/mercurial/wireproto.py
+++ b/mercurial/wireproto.py
@@ -604,7 +604,7 @@
data not captured by the 2-tuple and a new instance containing
the union of the two objects is returned.
"""
- return commandentry(func, args)
+ return commandentry(func, args=args)
# Old code treats instances as 2-tuples. So expose that interface.
def __iter__(self):
@@ -640,7 +640,7 @@
if k in self:
v = self[k]._merge(v[0], v[1])
else:
- v = commandentry(v[0], v[1])
+ v = commandentry(v[0], args=v[1])
else:
raise ValueError('command entries must be commandentry instances '
'or 2-tuples')
@@ -664,7 +664,7 @@
accepts. ``*`` is a special value that says to accept all arguments.
"""
def register(func):
- commands[name] = commandentry(func, args)
+ commands[name] = commandentry(func, args=args)
return func
return register
To: indygreg, #hg-reviewers
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list