D1974: narrow: import experimental extension from narrowhg revision cb51d673e9c5
durin42 (Augie Fackler)
phabricator at mercurial-scm.org
Thu Feb 1 23:40:25 UTC 2018
durin42 added a comment.
Should I add follow-up commits for the feedback? I think I'd slightly prefer doing that so that we import something that's as minimally modified as possible, and then fix it up all at once, but if you'd rather fix things here that's fine too.
(I agree with the things you caught, I just don't have time for them tonight - maybe tomorrow.)
INLINE COMMENTS
> indygreg wrote in __init__.py:11-14
> This seems inappropriate.
Yeah, I noticed this after doing the first big extraction. It's done in https://phab.mercurial-scm.org/D1980, but we can probably trivially fold that here. Do you have a preference?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1974
To: durin42, #hg-reviewers
Cc: indygreg, mercurial-devel
More information about the Mercurial-devel
mailing list