D2068: revlog: do not use delta for lfs revisions

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Wed Feb 7 22:35:43 UTC 2018


indygreg requested changes to this revision.
indygreg added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> revlog.py:408
> +                # do not use flags != 0 (ex. LFS) revision as delta base
> +                if revlog.flags(candidaterev) != REVIDX_DEFAULT_FLAGS:
> +                    continue

Same comment as previous review: this leaves a foot gun if we ever introduce revision flags that aren't related to content presence. We need something to help prevent this footgun.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2068

To: quark, indygreg, #hg-reviewers
Cc: mercurial-devel


More information about the Mercurial-devel mailing list