[PATCH] dirstate: drop explicitly-specified files that shouldn't match (BC)

[Yuya Nishihara]

On Sun, 11 Feb 2018 08:58:48 -0500, Augie Fackler wrote:
> On Sun, Feb 11, 2018 at 01:09:50PM +0900, Yuya Nishihara wrote:
> > # HG changeset patch
> > # User Yuya Nishihara <yuya at tcha.org>
> > # Date 1516963719 -32400
> > #      Fri Jan 26 19:48:39 2018 +0900
> > # Node ID ba8846546795996af10fe93db4317b855018d749
> > # Parent  91aac8e6604d1aa08b2683c1d4c7d1936f226e48
> > dirstate: drop explicitly-specified files that shouldn't match (BC)
> 
> Hmm. I'm not sure I like this behavior change. The current behavior is
> consistent with how an explicitly-tracked file shows up in status even
> if it's matched by .hgignore.
> 
> Any particular reason to go this route?

The current behavior is inconsistent with other commands, notably log and
files.

  $ hg files hg -X hg

Even more, it's inconsistent with status --change.

  $ hg status --all hg -X hg
  C hg
  $ hg status --all hg -X hg --change .

So I believe it's a bug of dirsate.walk().