D2231: narrow: fix for getting the username when running http server

idlsoft (Sandu Turcan) phabricator at mercurial-scm.org
Fri Feb 16 00:01:32 UTC 2018


idlsoft added inline comments.

INLINE COMMENTS

> martinvonz wrote in narrowbundle2.py:331
> But you're okay with this version for now? This commit is currently the bottom-most draft commit in the "committed" repo, so please accept it if you're okay with it. I would have accepted, but I saw this comment and wasn't sure if you thought this was bad enough to not queue it.

Ideally I would have liked to have a `userid` method in repo.ui (or something like that), and have it used by both `narrow`  and `acl` extension.
But I think this deserves a longer discussion, hence the quick fix.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2231

To: idlsoft, #hg-reviewers, durin42
Cc: martinvonz, indygreg, mercurial-devel


More information about the Mercurial-devel mailing list