D2333: py3: make sure we open the files in bytes mode
pulkit (Pulkit Goyal)
phabricator at mercurial-scm.org
Sun Feb 18 14:41:23 UTC 2018
pulkit updated this revision to Diff 5879.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2333?vs=5862&id=5879
REVISION DETAIL
https://phab.mercurial-scm.org/D2333
AFFECTED FILES
mercurial/posix.py
CHANGE DETAILS
diff --git a/mercurial/posix.py b/mercurial/posix.py
--- a/mercurial/posix.py
+++ b/mercurial/posix.py
@@ -113,24 +113,24 @@
if l:
if not stat.S_ISLNK(s):
# switch file to link
- fp = open(f)
+ fp = open(f, 'wb')
data = fp.read()
fp.close()
unlink(f)
try:
os.symlink(data, f)
except OSError:
# failed to make a link, rewrite file
- fp = open(f, "w")
+ fp = open(f, "wb")
fp.write(data)
fp.close()
# no chmod needed at this point
return
if stat.S_ISLNK(s):
# switch link to file
data = os.readlink(f)
unlink(f)
- fp = open(f, "w")
+ fp = open(f, "wb")
fp.write(data)
fp.close()
s = 0o666 & ~umask # avoid restatting for chmod
To: pulkit, #hg-reviewers, yuja
Cc: yuja, mercurial-devel
More information about the Mercurial-devel
mailing list