D1849: lfs: remove internal url in test

Thu Jan 11 06:04:27 UTC 2018

mharbison72 added a comment.

  Yeah, I’ve been ignoring this failure. I thought I mentioned it back when this was first brought over. I’m assuming that FB will start using the built in extension and tests soon, and I didn’t want to drop test coverage on you like that.  Thanks for fixing it.

INLINE COMMENTS

> blobstore.py:239
>                  p = ptrmap.get(response['oid'], None)
> -                if error['code'] == 404 and p:
> -                    filename = getattr(p, 'filename', 'unknown')

It looks like we still need the ‘if p’ test.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1849

To: quark, #hg-reviewers
Cc: mharbison72, mercurial-devel