D1813: bookmarks: add bookmarks to hidden revs if directaccess config is set
yuja (Yuya Nishihara)
phabricator at mercurial-scm.org
Fri Jan 12 13:31:07 UTC 2018
yuja added a comment.
Queued, thanks.
INLINE COMMENTS
> bookmarks.py:853
> + repo.ui.warn(_("bookmarking hidden changeset %s\n") % \
> + (', '.join(hiddenrevs)))
> marks.applychanges(repo, tr, changes)
FYI, it loops over bookmark names with the same `rev`, so
`hiddenrevs` would have at most one element, and the second
`unhidehashlikerevs()` call would be unnecessary.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1813
To: pulkit, #hg-reviewers, yuja
Cc: yuja, mercurial-devel
More information about the Mercurial-devel
mailing list