D3665: graph: improve graph output by using Unicode characters

[Sean Farley]

spectral (Kyle Lippincott) <phabricator at mercurial-scm.org> writes:

> spectral added a comment.
>
>
>   In https://phab.mercurial-scm.org/D3665#58616, @smf wrote:
>   
>   > johnstiles (John Stiles) <phabricator at mercurial-scm.org> writes:
>   >
>   > > johnstiles added a comment.
>   > > 
>   > >   Hi there @indygreg and @yuja  -- are you happy with the diff as it currently stands? Do you think this needs any additional work?
>   >
>   > Sorry for the late reply; was having email filtering issues (hopefully
>   >  fixed now).
>   >
>   > Overall, I'm +0 on it because I think the "real" solution to this is to
>   >  templatize the graph glpyhs so any user could use whatever unicode they
>   >  desire. However, that's a tall order I wouldn't put on you so I'm fine
>   >  with putting this in and adding a note along the lines of, "the path to
>   >  get this in core is to get the graph log templated."
>   
>   
>   I had originally pushed for this to be templating or at least additional configuration for the graphlog, we currently have ways of changing the | and : markers via config (not template), but these don't support unicode because of https://www.mercurial-scm.org/repo/hg/file/tip/mercurial/graphmod.py#l476, which is for this: https://www.mercurial-scm.org/repo/hg/file/tip/tests/test-glog.t#l3072

So, you'd add more config knobs and fix that issue?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-devel/attachments/20180614/0328fc17/attachment.asc>