D3828: rebase: add **opts to _prepareabortorcontinue

[sushil khanchi]

@pulkit I have added a new argument in _prepareabortorcontinue. Now I think
there is no need to split that patch, if I am not wrong. We can leave this
patch here.
Thanks :)

On Fri, Jun 22, 2018 at 7:48 PM, pulkit (Pulkit Goyal) <
phabricator at mercurial-scm.org> wrote:

> pulkit added inline comments.
>
> INLINE COMMENTS
>
> > rebase.py:328
> >
> > -    def _prepareabortorcontinue(self, isabort):
> > +    def _prepareabortorcontinue(self, isabort, **opts):
> >          try:
>
> As mentioned on IRC also, we should prevent using keyword arguments
> because in Python 3, we need to convert the keys to unicodes and then maybe
> back to bytes too. Can't we just pass this as a dictionary or add a new
> argument?
>
> REPOSITORY
>   rHG Mercurial
>
> REVISION DETAIL
>   https://phab.mercurial-scm.org/D3828
>
> To: khanchi97, #hg-reviewers
> Cc: pulkit, mercurial-devel
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-devel/attachments/20180622/9fd31a02/attachment-0002.html>