D2604: tests: add tests about diff quality
indygreg (Gregory Szorc)
phabricator at mercurial-scm.org
Sat Mar 3 21:24:26 UTC 2018
indygreg requested changes to this revision.
indygreg added a comment.
This revision now requires changes to proceed.
Can you please fix the Python 3 compatibility issues? If you want to push back, we can do it as a follow-up.
INLINE COMMENTS
> test-diff-antipatience.t:14
> + $ hg init
> + >>> open('a', 'w').write('\n'.join(list('a' + 'x' * 10 + 'u' + 'x' * 30 + 'a\n')))
> + $ hg commit -m 1 -A a
This should be `'wb'` for Python 3 compatibility. And it should use `b''` literals.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2604
To: quark, #hg-reviewers, indygreg
Cc: indygreg, mercurial-devel
More information about the Mercurial-devel
mailing list