D2720: debugcommands: introduce actions to perform deterministic reads

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Fri Mar 9 16:14:24 UTC 2018


indygreg added a comment.


  In https://phab.mercurial-scm.org/D2720#44221, @mharbison72 wrote:
  
  > This patch seems to deadlock on Windows when running test-ssh-proto-unbundle.t.  There are two python processes idling:
  >
  > Past experience says that something needs to be flushed- stdout (and maybe stderr?) are full buffered on Windows IIRC.  The following failure with this patch might also point to that:
  
  
  Hmmm.
  
  We explicitly create the pipes between the processes as unbuffered (`bufsize=0`). That being said, I would not at all be surprised if we need to throw a `flush()` in here somewhere.
  
  Could you please run the test with `run-tests.py -d` and see where it is deadlocking?
  
  The test failure due to the `o>` block is likely due to buffering or a race condition when writing to stdout of the `hg debugwireproto` process. I'll look into that after we fix the deadlock (since fixing might change order of things and I don't want to debug this in a system that is changing).

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2720

To: indygreg, #hg-reviewers
Cc: mharbison72, mercurial-devel


More information about the Mercurial-devel mailing list