D2791: hgweb: refactor fake file object proxy for archiving

[martinvonz (Martin von Zweigbergk)]

martinvonz added inline comments.

INLINE COMMENTS

> request.py:294
> +class offsettrackingwriter(object):
> +    """A file object like object that is append only and tracks write count.
> +

s/file object like object/file-like object/ ?
s/append only/append-only/ ?

> request.py:319
> +    def flush(self):
> +        pass
> +

IIUC, the old code would forward the call via __getattr__, but the new code ignores it. Any practical consequence? I don't know what flush() on a WSGI request does.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2791

To: indygreg, #hg-reviewers, durin42
Cc: martinvonz, mercurial-devel