D2934: forget: add --confirm option

[pulkit (Pulkit Goyal)]

pulkit requested changes to this revision.
pulkit added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> cmdutil.py:2047
>  
> +    if confirm:
> +        filenames = ' '.join(forget)

I think the right behavior should be to ask for each file and forget the ones which user confirmed to forget.

> test-add.t:293
> +  $ hg up -qC .
> +  $ hg forget foo --confirm << EOF
> +  > n

This is not reading 'n' as an input here and rather going for the default value. You should set `ui.interactive` to True.

> test-add.t:300
> +  R foo
> +
> +  $ cd ..

Please add more tests involving multiple files at once.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2934

To: khanchi97, #hg-reviewers, av6, pulkit
Cc: yuja, pulkit, av6, mercurial-devel