D2851: wireproto: define and implement protocol for issuing requests

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Sat Mar 24 14:13:51 UTC 2018


yuja added inline comments.

INLINE COMMENTS

> wireprotocol.txt:486
> +    +-----------+
> +    | Flags (4) |
> +    +===========+===================================================|

Nit: The order of Type and Flags seems a bit confusing. I read it as
`flags << 4 | type` since this is a little-endian (so naturally LSB-first) protocol.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2851

To: indygreg, #hg-reviewers, durin42
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list