D2943: grep: fixes errorneous output of grep in forward order
yuja (Yuya Nishihara)
phabricator at mercurial-scm.org
Tue Mar 27 12:34:33 UTC 2018
yuja requested changes to this revision.
yuja added a comment.
This revision now requires changes to proceed.
> This patch keeps the matches dictionary until
> the end of this window and clears it at once when this window ends.
This is really helpful while reading the patch. Perhaps it's worth adding
an inline comment?
The change looks good, but can't be applied on the current tip. Can you
rebase?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2943
To: sangeet259, #hg-reviewers, yuja
Cc: yuja, mercurial-devel
More information about the Mercurial-devel
mailing list