D3433: httppeer: detect redirect to URL without query string (issue5860)

mharbison72 (Matt Harbison) phabricator at mercurial-scm.org
Wed May 2 17:28:03 UTC 2018


mharbison72 added a comment.


  In https://phab.mercurial-scm.org/D3433#54703, @indygreg wrote:
  
  > I have no clue how this test would be failing on Windows but not on other platforms :/
  
  
  Me either.  But I didn't see it in the docs for this class, or when I ran `dir(URLError)`.  (I also tried on FreeBSD 11, where the test works.)  So maybe this is being added in at runtime?  While I'd like to see the tests green on stable, I'm more worried about if this is laying on other error paths for non-debug commands on Windows, that generally aren't exercised.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3433

To: indygreg, #hg-reviewers
Cc: mharbison72, mercurial-devel


More information about the Mercurial-devel mailing list