D5258: manifest: perform cheap checks before potentially allocating memory
durin42 (Augie Fackler)
phabricator at mercurial-scm.org
Tue Nov 13 11:42:56 UTC 2018
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGda4478ca0e32: manifest: perform cheap checks before potentially allocating memory (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5258?vs=12507&id=12512
REVISION DETAIL
https://phab.mercurial-scm.org/D5258
AFFECTED FILES
mercurial/cext/manifest.c
CHANGE DETAILS
diff --git a/mercurial/cext/manifest.c b/mercurial/cext/manifest.c
--- a/mercurial/cext/manifest.c
+++ b/mercurial/cext/manifest.c
@@ -137,13 +137,13 @@
return MANIFEST_TOO_SHORT_LINE;
}
next++; /* advance past newline */
- if (!realloc_if_full(self)) {
- return MANIFEST_OOM; /* no memory */
- }
if (prev && strcmp(prev, data) > -1) {
/* This data isn't sorted, so we have to abort. */
return MANIFEST_NOT_SORTED;
}
+ if (!realloc_if_full(self)) {
+ return MANIFEST_OOM; /* no memory */
+ }
l = self->lines + ((self->numlines)++);
l->start = data;
l->len = next - data;
To: durin42, #hg-reviewers
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list