[PATCH 1 of 2] tests: configure fsmonitor.mode=paranoid always if fsmonitor is used

FUJIWARA Katsunori foozy at lares.dti.ne.jp
Fri Oct 12 17:50:19 UTC 2018


# HG changeset patch
# User FUJIWARA Katsunori <foozy at lares.dti.ne.jp>
# Date 1539328028 -32400
#      Fri Oct 12 16:07:08 2018 +0900
# Node ID 2994abbbfddc09425be23a84423d34be34d474a9
# Parent  c3b7d9c54edd045fd463011faa736ef4e5fdc8f9
# Available At https://bitbucket.org/foozy/mercurial-wip
#              hg pull https://bitbucket.org/foozy/mercurial-wip -r 2994abbbfddc
# EXP-Topic issue5938
tests: configure fsmonitor.mode=paranoid always if fsmonitor is used

This forces fsmonitor extension execute "paranoid" code path.

Strict speaking, we should make fsmonitor-run-tests.py accept own
specific options, but there is no code path, which is disabled in
"paranoid" mode, at least now. Therefore, this solution seems
reasonable enough.

diff --git a/tests/fsmonitor-run-tests.py b/tests/fsmonitor-run-tests.py
--- a/tests/fsmonitor-run-tests.py
+++ b/tests/fsmonitor-run-tests.py
@@ -123,6 +123,12 @@ def run():
         runtestsargv.extend([
             '--extra-config',
             'extensions.fsmonitor=',
+            # specify fsmonitor.mode=paranoid always in order to force
+            # fsmonitor extension execute "paranoid" code path
+            #
+            # TODO: make fsmonitor-run-tests.py accept specific options
+            '--extra-config',
+            'fsmonitor.mode=paranoid',
             '--blacklist',
             blacklist,
         ])


More information about the Mercurial-devel mailing list