D4788: narrow: don't do the dirstate dance if ellipses is not enabled
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Tue Oct 2 16:17:11 UTC 2018
martinvonz accepted this revision.
martinvonz added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> narrowcommands.py:286-287
> + ds.setparents(node.nullid, node.nullid)
> + with wrappedextraprepare,\
> + repo.ui.configoverride(overrides, 'widen'):
> + exchange.pull(repo, remote, heads=common)
No need to change this, but FYI, I think the config override is one of the context managers that do their setup in `__enter__` (not `__init__`), so it should be fine to assign `repo.ui.configoverride(overrides, 'widen')` to a variable if wanted to fit this on one line
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4788
To: pulkit, durin42, #hg-reviewers, martinvonz
Cc: martinvonz, mercurial-devel
More information about the Mercurial-devel
mailing list