D5019: pager: disable auto pager if we think it doesn't support F, R, X

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Fri Oct 12 18:24:14 UTC 2018


indygreg added a comment.


  I need to review this on a fresher brain. But I'll be honest, I'm not sure how I feel about this.
  
  Do you know of other programs that jump through similar hoops to properly set up a pager?

INLINE COMMENTS

> ui.py:1120
> +        desiredargs = 'FRrX'
> +        for ch in lessenvvar:
> +            if ch == '-':

Won't this iterate integers on Python 3?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5019

To: spectral, #hg-reviewers
Cc: indygreg, mercurial-devel


More information about the Mercurial-devel mailing list