D4522: narrowspec: limit patterns to path: and rootfilesin: (BC)
indygreg (Gregory Szorc)
phabricator at mercurial-scm.org
Tue Sep 11 21:56:13 UTC 2018
indygreg added a subscriber: martinvonz.
indygreg added a comment.
Looking through this code a bit more, it appears that there is a not-in-core "remote expansion" wire protocol command that recognizes the `include:` prefix and asks the server to expand it. This series will stop that from working.
I didn't notice this at first because we have no tests for it.
I //think// Google's server relies on this feature.
@martinvonz how do you want to proceed? Should we nuke the `include:` feature in core? Or do you want me to refactor this series to support the `include:` on user-provided commands?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4522
To: indygreg, durin42, #hg-reviewers
Cc: martinvonz, mjpieters, mercurial-devel
More information about the Mercurial-devel
mailing list