D4526: narrow: validate spec files are well-formed during clone (BC)

[indygreg (Gregory Szorc)]

indygreg added inline comments.

INLINE COMMENTS

> martinvonz wrote in test-narrow-clone-no-ellipsis.t:133
> Maybe "file:" was just a typo for "path:" so it's better to replace it by "path:" (instead of having both)?

I was wondering about that too. I agree it feels wrong. I didn't feel like spending the brain cycles on it.

> martinvonz wrote in test-narrow-clone.t:279
> Any idea why this changed? Should it actually change in this patch?

It changed because there are multiple layers of validation. And the layer added by this patch occurs before the validation is performed in the exchange layer (the exchange layer is what's printing the removed line).

The new behavior feels better to me because it fails faster.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4526

To: indygreg, durin42, #hg-reviewers
Cc: martinvonz, mercurial-devel