D4606: narrow: when writing treemanifests, skip inspecting directories outside narrow

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Mon Sep 17 15:55:16 UTC 2018


martinvonz added inline comments.

INLINE COMMENTS

> localrepo.py:2134-2135
> +                    # ignoring things outside of narrowspec in most cases. The
> +                    # one case where we might have files outside the narrowspec
> +                    # at this point is merges, and we already error out in the
> +                    # case where the merge has files outside of the narrowspec,

Note that that the merge will fail with "...which is not *yet* supported" (emphasis added). It's probably going to be a long time before we support that case, because it will probably involve indicating the in the mergestate which side of the merge to indicate which side of the merge to choose for these files outside the narrowspec. But that's far enough away that it shouldn't block this patch. I'm mentioning it here just so others know what my plans for that were.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4606

To: spectral, #hg-reviewers
Cc: martinvonz, yuja, mercurial-devel


More information about the Mercurial-devel mailing list