D6695: transplant: added support for --abort flag

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Wed Aug 7 21:25:08 UTC 2019


pulkit added inline comments.

INLINE COMMENTS

> transplant.py:416
>  
> +    def clear(self):
> +        """clear the state file if it exists"""

We already have `self.unlog` doing the same here.

> transplant.py:421
> +
> +    def abort(self, ui ,repo):
> +        """logic to abort an interrupted transplant"""

the `,` after ui is misplaced a bit

> transplant.py:705
> +                raise error.Abort(_('no transplant to abort'))
> +            tp.abort(ui, repo)
> +            return

`return tp.abort(...)` here

> transplant.py:801
>          continuefunc=continuetransplant,
>          statushint=_('To continue:    hg transplant --continue\n'
> +                     'To abort:       hg transplant --abort'),

IIUC, we don't need to manually pass statushint and cmdhint now.

> test-transplant.t:466
> +  working directory is now at e8643552fde5
> +Repo log after abort
> +  $ hg glog

A better candidate here will be to show `hg status -v` as that will show whether there is an unfinished transplant or not.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6695/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6695

To: taapas1128, #hg-reviewers
Cc: pulkit, mjpieters, mercurial-devel


More information about the Mercurial-devel mailing list