[PATCH 2 of 3] copies: extract an explicit `computechangesetfilesadded` method from context
Pierre-Yves David
pierre-yves.david at ens-lyon.org
Tue Aug 6 13:18:56 UTC 2019
# HG changeset patch
# User Pierre-Yves David <pierre-yves.david at octobus.net>
# Date 1560343342 -3600
# Wed Jun 12 13:42:22 2019 +0100
# Node ID f6b2517c3651915610cee753ff8351e90078685d
# Parent fc8e461200c7262246ebd610100bcf9a75ded461
# EXP-Topic extrameta
# Available At https://bitbucket.org/octobus/mercurial-devel/
# hg pull https://bitbucket.org/octobus/mercurial-devel/ -r f6b2517c3651
copies: extract an explicit `computechangesetfilesadded` method from context
Right now, the logic around changeset centric added files data are buried into
the "changectx" code. We extract this code in a dedicated method (in the copies
module) for clarity. This clarity will help to explicitly compute and caches
these data in the future.
diff --git a/mercurial/context.py b/mercurial/context.py
--- a/mercurial/context.py
+++ b/mercurial/context.py
@@ -459,12 +459,7 @@ class changectx(basectx):
(source == 'compatibility' and
self._changeset.filesadded is not None)):
return self._changeset.filesadded or []
-
- added = []
- for f in self.files():
- if not any(f in p for p in self.parents()):
- added.append(f)
- return added
+ return scmutil.computechangesetfilesadded(self)
def filesremoved(self):
source = self._repo.ui.config('experimental', 'copies.read-from')
if (source == 'changeset-only' or
diff --git a/mercurial/scmutil.py b/mercurial/scmutil.py
--- a/mercurial/scmutil.py
+++ b/mercurial/scmutil.py
@@ -1984,3 +1984,12 @@ def bookmarkrevs(repo, mark):
"ancestors(head() and not bookmark(%s)) - "
"ancestors(bookmark() and not bookmark(%s))",
mark, mark, mark)
+
+def computechangesetfilesadded(ctx):
+ """return the list of files added in a changeset
+ """
+ added = []
+ for f in ctx.files():
+ if not any(f in p for p in ctx.parents()):
+ added.append(f)
+ return added
More information about the Mercurial-devel
mailing list