D6709: config: add --registered flag to show all known configs
navaneeth.suresh (Navaneeth Suresh)
phabricator at mercurial-scm.org
Sat Aug 10 19:02:53 UTC 2019
navaneeth.suresh added inline comments.
navaneeth.suresh added a subscriber: yuja.
INLINE COMMENTS
> marmoute wrote in test-config.t:232
> the `(default: False)` should be `(default: no)` too.
that change was there in my patch one revision before. i was asked by @pulkit to modify it as of now. would you recommend writing `no` to `fm.data()` also? the `defaultvalue` was not in `pycompat.bytestr()` after @yuja's suggestion. it would be better if we consider that as a string and change the function accordingly if we want to modify it. otherwise, it should print `no` and store `False`, print `False` on `hg showconfig --Tjson` in `defaultvalue`.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6709/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6709
To: navaneeth.suresh, #hg-reviewers, av6, marmoute
Cc: yuja, pulkit, marmoute, av6, mjpieters, mercurial-devel
More information about the Mercurial-devel
mailing list