D7768: commit: change default `editor` parameter to None
mharbison72 (Matt Harbison)
phabricator at mercurial-scm.org
Sat Dec 28 16:43:14 UTC 2019
mharbison72 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Flagged by PyCharm as a boolean not being callable later where it is used.
There's no actual bug here because of `if editor` checks before using.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D7768
AFFECTED FILES
mercurial/context.py
mercurial/localrepo.py
CHANGE DETAILS
diff --git a/mercurial/localrepo.py b/mercurial/localrepo.py
--- a/mercurial/localrepo.py
+++ b/mercurial/localrepo.py
@@ -2842,7 +2842,7 @@
date=None,
match=None,
force=False,
- editor=False,
+ editor=None,
extra=None,
):
"""Add a new revision to current repository.
diff --git a/mercurial/context.py b/mercurial/context.py
--- a/mercurial/context.py
+++ b/mercurial/context.py
@@ -2732,7 +2732,7 @@
date=None,
extra=None,
branch=None,
- editor=False,
+ editor=None,
):
super(memctx, self).__init__(
repo, text, user, date, extra, branch=branch
@@ -2893,7 +2893,7 @@
user=None,
date=None,
extra=None,
- editor=False,
+ editor=None,
):
if text is None:
text = originalctx.description()
To: mharbison72, #hg-reviewers
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list