D7576: hg-core: add configparser to library

Mon Dec 9 13:00:56 UTC 2019

Alphare added inline comments.

INLINE COMMENTS

> Cargo.toml:19
>  memchr = "2.2.0"
> +parking_lot = "0.9"
> +pest = "2.1.0"

"The current minimum required Rust version is 1.36". This disqualifies this crate from being used in `hg-core` right now. Good news is that it is supposed to offer improvements over existing `std` types like `Mutex` and the like, so it's nothing that would be hard to replace.

Also, I've seen complaints online about the lack of benchmarks of `parking_lot` against `std` types to back-up their claims for performance. I have not looked into it myself.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7576/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7576

To: indygreg, #hg-reviewers
Cc: Alphare, durin42, kevincox, mercurial-devel