D7641: rebase: use cmdutil.check_at_most_one_arg() for --confirm/--dry-run
pulkit (Pulkit Goyal)
phabricator at mercurial-scm.org
Tue Dec 17 16:02:33 UTC 2019
pulkit added a comment.
In D7641#113027 <https://phab.mercurial-scm.org/D7641#113027>, @yuja wrote:
>>> Spotted in a later patch, need to replace `_` back to `-` before printing output.
>>
>> Strings are immutable in Python, so it wasn't actually replaced, right? Or do I misunderstand your concern?
>
> Maybe he meant `opts[b'dry_run']` vs `--dry-run`. `*args` should follow
> underscore naming, but the printed option names don't.
Yep what Yuya said. Spotted in D7644 <https://phab.mercurial-scm.org/D7644>, test-rebase-obsolete.t, line 490.
REPOSITORY
rHG Mercurial
BRANCH
default
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D7641/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D7641
To: martinvonz, #hg-reviewers, pulkit
Cc: yuja, mercurial-devel
More information about the Mercurial-devel
mailing list