D5651: hgweb: don't use raw string for session vars

[indygreg (Gregory Szorc)]

indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  This r'' is leaking into the templating layer and causing an
  assertion failure.
  
  The r'' was added in https://phab.mercurial-scm.org/rHGd1fccbd50fcd081fc98c88f30701ba029d7c2505 (October 2017). Similar code
  in hgweb_mod.py was also changed in that changeset. hgweb_mod.py was
  updated in https://phab.mercurial-scm.org/rHGec46415ed826ba23872d2dae8f1710cf1d30ea35 (March 2018) to use webutil.sessionvars(),
  which doesn't use raw strings.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5651

AFFECTED FILES
  mercurial/hgweb/hgwebdir_mod.py

CHANGE DETAILS

diff --git a/mercurial/hgweb/hgwebdir_mod.py b/mercurial/hgweb/hgwebdir_mod.py
--- a/mercurial/hgweb/hgwebdir_mod.py
+++ b/mercurial/hgweb/hgwebdir_mod.py
@@ -510,7 +510,7 @@
         if style == styles[0]:
             vars['style'] = style
 
-        sessionvars = webutil.sessionvars(vars, r'?')
+        sessionvars = webutil.sessionvars(vars, '?')
         logourl = config('web', 'logourl')
         logoimg = config('web', 'logoimg')
         staticurl = (config('web', 'staticurl')



To: indygreg, #hg-reviewers
Cc: mercurial-devel