[PATCH STABLE] update: do not pass in user revspec as default destination (issue6044)
Pulkit Goyal
7895pulkit at gmail.com
Thu Jan 3 10:12:29 UTC 2019
On Wed, Jan 2, 2019 at 2:34 PM Boris FELD <boris.feld at octobus.net> wrote:
> LGTM but a second review is necessary I think.
>
> On 02/01/2019 02:04, Yuya Nishihara wrote:
> > # HG changeset patch
> > # User Yuya Nishihara <yuya at tcha.org>
> > # Date 1546389664 -32400
> > # Wed Jan 02 09:41:04 2019 +0900
> > # Branch stable
> > # Node ID 035f7a392747ac3fd720d3181e387bc42ca12845
> > # Parent 7542466b94e25ec658e64bd3d33105a59bebc53e
> > update: do not pass in user revspec as default destination (issue6044)
> >
> > When the revsingle() was introduced at 61c0df2b089a, it couldn't handle
> > revspec=0 (not '0') properly. That's probably why the default was set to
> > rev.
> >
> > This is technically BC since "hg update ''" was identical to "hg update
> '.'"
> > whereas "hg update -r ''" is "hg update", but I believe that's a bug
> given
> > no test fails with this change.
>
Looks fine to me. Queued this, many thanks!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-devel/attachments/20190103/dc71dd25/attachment-0002.html>
More information about the Mercurial-devel
mailing list