D5508: narrow: extract repo property for store narrowmatcher

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Wed Jan 16 07:29:48 UTC 2019


pulkit accepted this revision.
pulkit added inline comments.

INLINE COMMENTS

> localrepo.py:1227
>      @storecache(narrowspec.FILENAME)
> +    def _storenarrowmatch(self):
> +        if repository.NARROW_REQUIREMENT not in self.requirements:

In future, we can add a boolean `store` argument to `narrowmatch()` function. That will be better than accessing private attributes of the localrepo class.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5508

To: martinvonz, #hg-reviewers, pulkit
Cc: pulkit, mercurial-devel


More information about the Mercurial-devel mailing list