D5586: watchman: add verbose config knob
pulkit (Pulkit Goyal)
phabricator at mercurial-scm.org
Thu Jan 17 10:17:18 UTC 2019
pulkit added a comment.
In https://phab.mercurial-scm.org/D5586#82915, @indygreg wrote:
> This new config knob defaults to off and we're therefore changing the behavior to not warn when watchman is unavailable. This is a bit concerning to me because someone could have fsmonitor enabled and I don't think they'd ever get an error if watchman isn't working correctly.
>
> I support introducing the config knob. But I don't like silently suppressing watchman errors that could lead to false user expectations.
I on +1 with what @indygreg said. These warning messages have proved much helpful for us internally.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5586
To: lothiraldan, #hg-reviewers
Cc: pulkit, indygreg, mjpieters, mercurial-devel
More information about the Mercurial-devel
mailing list