D5496: revset: add "samebranch" keyword argument to the merge revset

[yuja (Yuya Nishihara)]

yuja added a comment.


  >   Maybe `anonymous`, defaulting to True?
  
  To all: the default can't be True. It would break the current `merge()`
  revset behavior. Only viable choice is to set the default to "don't care".
  
  And I think tri-state bool is confusing in this context. So, IMHO, it's
  better to add an argument taking a keyword string specifying constraint
  such as `merge(between="a-keyword-to-select-merges-of-named-branches")`.
  
  > That's in the glossary under `Branch, anonymous`, so not technically
  >  a merge, but I think it still conveys the point.
  
  I disagree. Merges of the same branch are pretty common if your team preferred
  merge-based strategy. I wouldn't explicitly call new head pulled from public
  repo as an anonymous head.
  
  It can also be wrong if you're using bookmarks.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5496

To: angel.ezquerra, #hg-reviewers
Cc: mharbison72, yuja, mercurial-devel