D6484: states: unified api for checking unfinished states(gsoc-19)
pulkit (Pulkit Goyal)
phabricator at mercurial-scm.org
Thu Jun 6 11:56:31 UTC 2019
pulkit added a comment.
In https://phab.mercurial-scm.org/D6484#94131, @taapas1128 wrote:
> @martinvonz I have completed steps 1 to 5 as you stated in the sequence above in `statecheck.py`. For the purpose of showing that it works without flaw, I redirected the API calls to the new API for both STATES and unfinished state and removed those from `cmdutil.py`. All that remains is a minor bug that I am facing with `hg bisect`. I will clear that soon enough. Do you want me to send the API integration and tests as a separate patch and API as another?
I think @martinvonz wants to say that we should split the whole work into nice small commits. This will help us to review it better and understand the whole change much better. The 1 to 5 are like, one commit should do one of those things.
I also agree with him, what do you think?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6484
To: taapas1128, durin42, martinvonz, #hg-reviewers
Cc: pulkit, mjpieters, Kwan, mercurial-devel
More information about the Mercurial-devel
mailing list