D6487: states: created new class to handle unified states(gsoc-19)

[pulkit (Pulkit Goyal)]

pulkit added inline comments.

INLINE COMMENTS

> statecheck.py:40
> +        self._allowcommit = allowcommit
> +        self._stopflag = stopflag
> +

We generally prepend `_` to variable names if they are private to that class. That is, we don't want them to be accessed outside of the class. This is just a coding guidelines which is quite usually followed. It will be nice, if we don't add `_` before variables which can be used outside the class. Like `clearable` maybe.

> statecheck.py:42
> +
> +    def _hintmessage(self):
> +        """returns the hint message corresponding to the command"""

nit: `def hint(..)`

> statecheck.py:61
> +
> +    def _statusmessage(self):
> +        """returns the status message corresponding to the command"""

nit: `def msg`

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6487

To: taapas1128, #hg-reviewers
Cc: pulkit, mercurial-devel