D6501: state: created new class statecheck to handle unfinishedstates

taapas1128 (Taapas Agrawal) phabricator at mercurial-scm.org
Tue Jun 18 07:49:07 UTC 2019


taapas1128 added inline comments.
taapas1128 marked 4 inline comments as done.

INLINE COMMENTS

> av6 wrote in state.py:151
> It's funny how Pulkit's comment is now at this line and looks like asking to add spaces around `=` here. But in this case `=` is not an operator, it's used to indicate keyword arguments. We don't want spaces around it (similarly to PEP8).
> 
> Bad:
> 
>   addunfinished(
>       'graft',
>       fname = 'graftstate',
>       clearable = True,
>       allowcommit = False,
>       cmdhint = _("use 'hg graft --continue' or 'hg graft --stop' to stop")
>   )
> 
> Good:
> 
>   addunfinished(
>       'graft',
>       fname='graftstate',
>       clearable=True,
>       allowcommit=False,
>       cmdhint=_("use 'hg graft --continue' or 'hg graft --stop' to stop")
>   )
> 
> Even better (as long as it fits into 79 characters per line):
> 
>   addunfinished(
>       'graft', 'graftstate', clearable=True, allowcommit=False,
>       cmdhint=_("use 'hg graft --continue' or 'hg graft --stop' to stop")
>   )
> 
> There's a lot of places where this needs to be fixed in this series, not just here.

Thank you I will take care from now on  :)

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6501/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6501

To: taapas1128, durin42, martinvonz, #hg-reviewers
Cc: av6, Kwan, pulkit, mjpieters, mercurial-devel


More information about the Mercurial-devel mailing list