D6503: statecheck: added support for STATES
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Wed Jun 19 22:33:05 UTC 2019
This revision is now accepted and ready to land.
martinvonz added inline comments.
martinvonz accepted this revision.
INLINE COMMENTS
> rebase.py:1954-1955
> + statemod.addunfinished('rebase', fname='rebasestate', stopflag=True)
> cmdutil.afterresolvedstates.append(
> ['rebasestate', _('hg rebase --continue')])
It seems like this should also be unified with the new tracking of unfinished operations. Will you have time to look into that after the current series?
> state.py:100-102
> def __init__(self, opname, fname, clearable=False, allowcommit=False,
> - cmdmsg="", cmdhint=""):
> + cmdmsg="", cmdhint="", statushint="", stopflag=False,
> + reportonly=False):
We should probably put all the boolean options together and the message overrides together (as they already are). Maybe move `stopflag` and `reportonly` before `cmdmsg`?
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6503/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6503
To: taapas1128, durin42, #hg-reviewers, martinvonz
Cc: mjpieters, martinvonz, pulkit, mercurial-devel
More information about the Mercurial-devel
mailing list