D7134: phabricator: use context manager form of progress in uploadchunks
Kwan (Ian Moody)
phabricator at mercurial-scm.org
Fri Nov 8 18:26:04 UTC 2019
Closed by commit rHGa78a65c33b5a: phabricator: use context manager form of progress in uploadchunks (authored by Kwan).
This revision was automatically updated to reflect the committed changes.
This revision was not accepted when it landed; it landed in state "Needs Review".
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D7134?vs=17494&id=17795
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D7134/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D7134
AFFECTED FILES
hgext/phabricator.py
CHANGE DETAILS
diff --git a/hgext/phabricator.py b/hgext/phabricator.py
--- a/hgext/phabricator.py
+++ b/hgext/phabricator.py
@@ -609,26 +609,25 @@
"""
ui = fctx.repo().ui
chunks = callconduit(ui, b'file.querychunks', {b'filePHID': fphid})
- progress = ui.makeprogress(
+ with ui.makeprogress(
_(b'uploading file chunks'), unit=_(b'chunks'), total=len(chunks)
- )
- for chunk in chunks:
- progress.increment()
- if chunk[b'complete']:
- continue
- bstart = int(chunk[b'byteStart'])
- bend = int(chunk[b'byteEnd'])
- callconduit(
- ui,
- b'file.uploadchunk',
- {
- b'filePHID': fphid,
- b'byteStart': bstart,
- b'data': base64.b64encode(fctx.data()[bstart:bend]),
- b'dataEncoding': b'base64',
- },
- )
- progress.complete()
+ ) as progress:
+ for chunk in chunks:
+ progress.increment()
+ if chunk[b'complete']:
+ continue
+ bstart = int(chunk[b'byteStart'])
+ bend = int(chunk[b'byteEnd'])
+ callconduit(
+ ui,
+ b'file.uploadchunk',
+ {
+ b'filePHID': fphid,
+ b'byteStart': bstart,
+ b'data': base64.b64encode(fctx.data()[bstart:bend]),
+ b'dataEncoding': b'base64',
+ },
+ )
def uploadfile(fctx):
To: Kwan, #hg-reviewers
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list