D7322: index: add a `has_node` method (API)
indygreg (Gregory Szorc)
phabricator at mercurial-scm.org
Fri Nov 8 19:44:13 UTC 2019
This revision now requires changes to proceed.
indygreg added inline comments.
indygreg requested changes to this revision.
INLINE COMMENTS
> revlog.c:2071
> + int ret = index_contains(self, args);
> + return PyBool_FromLong((long)ret);
> +}
`index_contains()` can return `-1` in many cases (including invalid input), which will cast to `True`. So this implementation needs improved.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D7322/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D7322
To: marmoute, indygreg, #hg-reviewers
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list