D7409: dispatch: add some assertions to give pytype a helping hand
durin42 (Augie Fackler)
phabricator at mercurial-scm.org
Tue Nov 19 03:51:37 UTC 2019
Closed by commit rHGac8fd215a776: dispatch: add some assertions to give pytype a helping hand (authored by durin42).
This revision was automatically updated to reflect the committed changes.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D7409?vs=18102&id=18229
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D7409/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D7409
AFFECTED FILES
mercurial/dispatch.py
CHANGE DETAILS
diff --git a/mercurial/dispatch.py b/mercurial/dispatch.py
--- a/mercurial/dispatch.py
+++ b/mercurial/dispatch.py
@@ -115,6 +115,8 @@
# In all cases we try to flush stdio streams.
if util.safehasattr(req.ui, b'fout'):
+ assert req.ui is not None # help pytype
+ assert req.ui.fout is not None # help pytype
try:
req.ui.fout.flush()
except IOError as e:
@@ -122,6 +124,8 @@
status = -1
if util.safehasattr(req.ui, b'ferr'):
+ assert req.ui is not None # help pytype
+ assert req.ui.ferr is not None # help pytype
try:
if err is not None and err.errno != errno.EPIPE:
req.ui.ferr.write(
@@ -1108,6 +1112,7 @@
repo = None
cmdpats = args[:]
+ assert func is not None # help out pytype
if not func.norepo:
# use the repo from the request only if we don't have -R
if not rpath and not cwd:
To: durin42, #hg-reviewers, dlax, indygreg
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list