D6939: sidedata: apply basic but tight security around exchange

Tue Oct 8 00:51:48 UTC 2019

marmoute added inline comments.
marmoute marked an inline comment as done.

INLINE COMMENTS

> martinvonz wrote in bundle2.py:1837-1838
> Isn't `bool()` redundant here?

It is redundant, but helping Raphaël work on Rust got me scared about boolean. I'll clean it up (either resend or followup)

> indygreg wrote in bundle2.py:2343
> Shouldn't this by `exp-sidedata`?

Hum, yeah. That would be safer. Updated code coming

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6939/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6939

To: marmoute, #hg-reviewers
Cc: indygreg, martinvonz, mercurial-devel