D6953: sidedatacopies: read rename information from sidedata
marmoute (Pierre-Yves David)
phabricator at mercurial-scm.org
Wed Oct 9 18:30:43 UTC 2019
marmoute added inline comments.
INLINE COMMENTS
> martinvonz wrote in changelog.py:369-371
> Calling the list of filenames `rawindices` is misleading. I see that you've changed this code to return an empty list of files when the list of indices was itself an empty list. That makes sense. Could you extract that to a separate patch ? Does it matter in practice for sidedata? Please explain in the commit message if it does. That patch would also assign the decoded list of indices to a variable called `files` or something like that.
> I see that you've changed this code to return an empty list of files when the list of indices was itself an empty list.
I dont' follow this sentence. What do you mean ?
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6953/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6953
To: marmoute, #hg-reviewers
Cc: martinvonz, mercurial-devel
More information about the Mercurial-devel
mailing list