D7061: convert: don't pass bytes to, or expect bytes from, emailparser

[martinvonz (Martin von Zweigbergk)]

martinvonz added inline comments.

INLINE COMMENTS

> gnuarch.py:301
>          try:
> -            catlog = self.catlogparser.parsestr(data)
> +            catlog = self.catlogparser.parsestr(encoding.unifromlocal(data))
>  

Is it right to depend on the user's preferred encoding (as I think `unifromlocal()` does)? Would it make sense to instead initialize `self.catlogparser = emailparser.BytesParser()`?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7061/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7061

To: Kwan, #hg-reviewers
Cc: martinvonz, mercurial-devel