D7121: copies: get copies information directly from _copies

[martinvonz (Martin von Zweigbergk)]

martinvonz added a comment.


  In D7121#104671 <https://phab.mercurial-scm.org/D7121#104671>, @marmoute wrote:
  
  > In D7121#104546 <https://phab.mercurial-scm.org/D7121#104546>, @martinvonz wrote:
  >
  >> In D7121#104543 <https://phab.mercurial-scm.org/D7121#104543>, @martinvonz wrote:
  >>
  >>>> Performance measurement does not show any significant performance movement. This
  >>>> is not surprising since p1copies() code is self._copies[0].
  >>>
  >>> My testing agrees with that. However, making the same change (well, the reverse of it) on top of D7070 <https://phab.mercurial-scm.org/D7070> makes very significant difference. I have no idea why.
  >>
  >> Actually, I may have spoken too soon. `hg perfpathcopies FIREFOX_BETA_59_END FIREFOX_BETA_60_BASE --config perf.run-limits='10.0-10'` yields:
  >>
  >>   before:
  >>   ! wall 4.595685 comb 4.600000 user 4.530000 sys 0.070000 (best of 10)
  >>   after:
  >>   ! wall 4.485065 comb 4.490000 user 4.440000 sys 0.050000 (best of 10)
  >>
  >> So there seems to be a measurable difference. Could just the function call overhead be that whole difference? Anyway, it doesn't seem worth spending time trying to figure out.
  >
  > Function call can have a large overhead, how many revision are we talking about here ?
  
  5627

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7121/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7121

To: marmoute, #hg-reviewers, martinvonz
Cc: martinvonz, mercurial-devel