D6848: narrow: add option for automatically removing unused includes
pulkit (Pulkit Goyal)
phabricator at mercurial-scm.org
Tue Sep 17 17:50:11 UTC 2019
pulkit added inline comments.
INLINE COMMENTS
> narrowcommands.py:331
> ('', 'removeinclude', [], _('old paths to no longer include')),
> + ('', 'auto-remove-includes', False,
> + _('automatically choose unused includes to remove (EXPERIMENTAL)')),
Following pattern of other flags, `auto-removeinclude(s)` seems better.
> martinvonz wrote in narrowcommands.py:332
> Even though it's marked EXPERIMENTAL? Or maybe I should do that and just drop the EXPERIMENTAL since the whole feature (narrow clones) is experimental anyway?
I don't have a strong opinion on having or dropping EXPERIMENTAL, but we should have some help text. It can be added under verbose section.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6848/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6848
To: martinvonz, durin42, #hg-reviewers
Cc: pulkit, rdamazio, mercurial-devel
More information about the Mercurial-devel
mailing list