D8357: rust-chg: add brief comment about initial capacity of temp_sock_path()

Alphare (Raphaël Gomès) phabricator at mercurial-scm.org
Fri Apr 3 12:18:52 UTC 2020


Alphare added a comment.
Alphare accepted this revision.


  (I'll be re-pasting all of my comments that got lost in emails for this series)
  
  Maybe I'm completely off-base here, but pid length varies with the OS, the architecture and user preferences. On Linux 64 bits it can be 4194304, 32768 for 32bits and 99999 for FreeBSD. We could add constants, but I feel like it would be a lot of work for not a lot of gain.
  
  This patch looks good no matter what.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8357/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8357

To: yuja, #hg-reviewers, Alphare
Cc: Alphare, mercurial-devel


More information about the Mercurial-devel mailing list