D8425: wait-on-file: don't quote arithmetic argument

mharbison72 (Matt Harbison) phabricator at mercurial-scm.org
Wed Apr 15 22:10:44 UTC 2020


mharbison72 added a comment.
mharbison72 accepted this revision.


  I couldn't reproduce the problem on 10.14 with or without this.  But I can confirm that it appears to fix the issue on MSYS.
  
    --- g:/Users/test/projects/hg-default-x86_64/Win7_x86_64_hg_tests/build/tests/test-persistent-nodemap.t
    +++ g:/Users/test/projects/hg-default-x86_64/Win7_x86_64_hg_tests/build/tests/test-persistent-nodemap.t.err
    @@ -354,22 +388,19 @@
       $ wait-on-file 20 sync-txn-pending && \
       > hg debugnodemap --metadata && \
       > wait-on-file 20 sync-txn-close sync-repo-read
    +  \Users\test\projects\hg-default-x86_64\Win7_x86_64_hg_tests\build\tests/testlib/wait-on-file: line 16: ("20" * "600") / 180 : syntax error: operand expected (error token is ""20" * "600") / 180 ")

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8425/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8425

To: marmoute, #hg-reviewers, mharbison72
Cc: mharbison72, mercurial-devel


More information about the Mercurial-devel mailing list