D7173: packaging: stage files and dynamically generate WiX installer
indygreg (Gregory Szorc)
phabricator at mercurial-scm.org
Sat Feb 1 05:01:57 UTC 2020
indygreg added a comment.
In D7173#118947 <https://phab.mercurial-scm.org/D7173#118947>, @mharbison72 wrote:
>> This change also means that Inno and WiX are now using very similar code for managing the install layout. This means that on disk both packages are nearly identical. The differences in install layout are as follows:
>> ...
>
> I diffed the WiX and Inno installs side by side, and there are a few more differences right before the 5.3 release. I don't think there's anything critical, but just in case there could be an issue:
>
> - Inno installs `backports.configparser`, `certifi`, `dulwich`, `keyring`, `urllib3`, and `win32ctypes` in library.zip.
I think these are related to `TortoiseHg` somehow. But I could be wrong about that. I'd favor unifying the set of packages between the installers so everything is consistent.
> - Inno installs additional *.pyc files in `wsgiref`.
> - ConfigParser.pyc is 24K in WiX, 1.5K in Inno. Probably related to the backport package being present in Inno.
> - WiX installs a `mercurial.rc`, corresponding to `contrib/win32/mercurial.ini`; Inno does not.
I thought I had fixed this discrepancy...
Anyway, I will stamp any patches to converge the final install layout. As for what release, I don't have strong opinions. The Python 3 installer (presumably next release) would be a good time to make any significant changes we're scared of.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D7173/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D7173
To: indygreg, #hg-reviewers, durin42
Cc: mharbison72, durin42, mercurial-devel
More information about the Mercurial-devel
mailing list